fix call/delagate call tracking bug #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
fselmo
approved these changes
Sep 22, 2025
Owner
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
Can confirm this passes the EEST tests in ethereum/execution-spec-tests#2182
fselmo
merged commit b8ad380
into
fselmo:feat/amsterdam-fork-and-block-access-lists
3 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue ethereum#1434
The problem was that CALLCODE and DELEGATECALL operations were not tracking the code_address as the TargetContract in the block access list.
How was it fixed?
The TargetContract should be the address whose code is being executed, not the current contract address. I've added track_address_access calls for the code_address in both callcode() (line 497) and delegatecall() (line 637) functions to properly track these accesses.